Skip to content

Conversation

@logan-markewich
Copy link
Collaborator

damn

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jul 25, 2025
raise ValueError(
"ChatMode.REACT and ChatMode.OPENAI are now deprecated and removed. "
"Please use the ReActAgent or FunctionAgent classes from llama_index.core.agent.workflow "
"to create an agent with a query engine tool."
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of all the changes here, this will be the most breaking. However, users would have still been getting deprecation messages if they were still using the default .as_chat_engine() method

@logan-markewich logan-markewich marked this pull request as draft July 25, 2025 05:09
@logan-markewich logan-markewich marked this pull request as ready for review July 28, 2025 17:11
Copy link
Contributor

@adrianlyjak adrianlyjak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😵‍💫

@logan-markewich logan-markewich merged commit cf7b1ed into logan/v0.13.0_split Jul 29, 2025
8 of 9 checks passed
@logan-markewich logan-markewich deleted the logan/delete_old_agents branch July 29, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants