fix: make run_step return all the events produced by a step #18082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
logan-markewich
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously,
run_stepwould return only the event produced by steps in their return value. But events can also be produced using thesend_eventmethod of the Context, and those were ignored during stepwise execution. This PR fixes that issue.Note: I had to change the return type of
run_stepfrom a single event to a list of events, which is consistent with what the method is supposed to do: returning all the events that were produced in the step. While technically this is a breaking change, since the previous version couldn't work I propose we roll out this change as a bugfix instead.Follow-up of #17898