Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- fix: rssReader support customized user-agent #18076

Merged

Conversation

jingyi-zhao-01
Copy link
Contributor

@jingyi-zhao-01 jingyi-zhao-01 commented Mar 10, 2025

Description

  • some rss sources implement cloudflare to prevent being abused, such as rsshub
  • by allow the feedparser to accccept a user-agent, this problem can be eliminated

Fixes # (issue)

New Package?

No

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

Signed-off-by: jingyi <zhao.elton@gmail.com>
Signed-off-by: jingyi <zhao.elton@gmail.com>
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Mar 10, 2025
@jingyi-zhao-01
Copy link
Contributor Author

i got stuck on the rule of naming on testcases, do we have any docs on that ?

_ ERROR collecting llama-index-integrations/readers/llama-index-readers-web/tests/test_readers_rss.py _
ImportError while importing test module 'llama-index-integrations/readers/llama-index-readers-web/tests/test_readers_rss.py'.
Hint: make sure your test modules/packages have valid Python names.

@logan-markewich logan-markewich merged commit afe3dcb into run-llama:main Mar 10, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants