Fix the TypeError in the upsert_triplet method of the NeptuneBaseGrap…

[Uokoroafor]

Description

When trying to build a Neptune knowledge graph using the llama index NeptuneBaseGraphStore class. The upsert method leads to a TypeError with description "not enough arguments to format string".

This is because query below has three %s placeholders but prepared_statement only provides two values leading to the TypeError - shown below.

CURRENT METHOD

def upsert_triplet(self, subj: str, rel: str, obj: str) -> None:
        """Add triplet to the graph."""
        query = """
            MERGE (n1:`%s` {id:$subj})
            MERGE (n2:`%s` {id:$obj})
            MERGE (n1)-[:`%s`]->(n2)
        """

        prepared_statement = query % (
            self.node_label.replace("`", ""),
            rel.replace(" ", "_").replace("`", "").upper(),
        )

        self.query(
            prepared_statement,
            {"subj": subj.replace("`", ""), "obj": obj.replace("`", "")},
        )

IMPLEMENTED FIX
To ensure that the query string receives three values instead of two, I have included the self.node_label for both lines.

def upsert_triplet(self, subj: str, rel: str, obj: str) -> None:
        """Add triplet to the graph."""
        query = """
            MERGE (n1:`%s` {id:$subj})
            MERGE (n2:`%s` {id:$obj})
            MERGE (n1)-[:`%s`]->(n2)
        """

        prepared_statement = query % (
            self.node_label.replace("`", ""),
            self.node_label.replace("`", ""),
            rel.replace(" ", "_").replace("`", "").upper(),
        )

        self.query(
            prepared_statement,
            {"subj": subj.replace("`", ""), "obj": obj.replace("`", "")},
        )

I proposed this in Issue #18044 and the dosubot agreed with the proposal.

Fixes #18044

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

• Yes
• No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

• Yes
• No

Type of Change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

• I added new unit tests to cover this change
• I believe this change is already covered by existing unit tests

Suggested Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation
• [ ] I have added Google Colab support for the newly added notebooks.
• My changes generate no new warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I ran make format; make lint to appease the lint gods