Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] deps in llama-index-networks/examples #17665

Merged

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Jan 29, 2025

Description

In the example apps for llama-index-networks, we have llama-index version requirement set to ^0.14.0 which fails when trying to install because the package is still in v0.12.xx.

(I'm giving a quick demo on this tmr as an example of "what's next?" post basic RAG)

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • No

I don't think I need to update anything here as llama-index-networks version is fine, its just the example apps that needed fixing.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 29, 2025
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spooky, thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
@logan-markewich logan-markewich merged commit d73b99d into run-llama:main Jan 29, 2025
11 checks passed
@logan-markewich
Copy link
Collaborator

I remember there was at least one package we published under your pypi @nerdai -- it might be this one 😅 Lets see if the publish action works

@nerdai
Copy link
Contributor Author

nerdai commented Jan 29, 2025

Haha yeah this is the one. Though I think Jerry has since accepted the invite I sent him to become owner/admin for this package in PyPi. 😂

@nerdai
Copy link
Contributor Author

nerdai commented Jan 29, 2025

Boo looks like it fails due to missing README's in the example apps? 🤔

      FileNotFoundError: Readme path `/home/runner/work/llama_index/llama_index/llama-index-networks/examples/privacy_safe_retrieval/contributor-1/README.md` does not exist.

@logan-markewich
Copy link
Collaborator

yea looks good (it actually tried to publish the contributor-1 and contributor-2 packages etc, but otherwise looks good!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants