Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API key and fix colab link in deepseek.ipynb #17664

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Jan 29, 2025

Description

Hey guys,

Just saw that an api key secret was left in the deepseek.ipynb, which I guess we might want to remove. Also, noticed that the colab link points to grok instead of deepseek. This PR addresses both of these issues.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 29, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@logan-markewich
Copy link
Collaborator

wow whoops, surprised github didn't detect that. Thanks! Revoking that key now 😓

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2025
@logan-markewich logan-markewich enabled auto-merge (squash) January 29, 2025 21:09
@nerdai
Copy link
Contributor Author

nerdai commented Jan 29, 2025

Yeah Github fail, for sure! Sounds good. 🍻

@logan-markewich logan-markewich merged commit b15182f into run-llama:main Jan 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants