Guess image_mimetype
for ImageNode
#17422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a couple of enhancements when working with
ImageNode
's:image_mimetype
field fromimage_path
if provided. (This is somewhat breaking as before we were guessing the mimetype from the path)TextNode
we add forward-compatibility by enabling construction via a image media resource type.Also, I made an implementation change for validating
data
andmimetype
fields of aMediaResource
. Specifically, I opt to usefield_validator
overmodel_validator
to be able to handle the validation of these two separate fields "separately".Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.