Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Move JSONalyzeQueryEngine to experimental #17110

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Nov 29, 2024

Description

There is a security bug discovered for JSONalyzeQueryEngine where it was shown one could perform arbitrary file creation via SQL/Prompt injection. As a result, moving this query engine out of core and into experimental. Warning messages about the risks involved in using this query engine have been added.

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Security Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 29, 2024
@nerdai nerdai enabled auto-merge (squash) November 29, 2024 18:21
@nerdai nerdai disabled auto-merge November 29, 2024 18:54
@nerdai nerdai merged commit bf28207 into main Nov 29, 2024
9 of 11 checks passed
@nerdai nerdai deleted the nerdai/sql-lite-security-bug branch November 29, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants