Fix drawing for HITL #16624
Merged
Fix drawing for HITL #16624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
llama-index-utils/llama-index-utils-workflow/llama_index/utils/workflow/draw.py
Outdated
Show resolved
Hide resolved
nerdai
changed the title
BlockingEvent and UnblockingEvent
logan-markewich
approved these changes
Oct 21, 2024
|
Looks like deeplake update 😓 Safe to ignore those tests |
🥲 okay will do. But what about coveralls check? I looked at the tests that we currently have and it wasn't immediately obvious to me how we could test the produced If we deem this as really important, I can spend some time tinkering tests perhaps, tho I don't yet know how would I go about that. |
|
Eh, tests are less important for this drawing package (pretty hard to test I agree) -- any test would just generate the png but you can't really check it, only ensure that it didn't break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes drawing of Workflows that use HITL pattern. It introduces a conceptual "external_step"
Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.