Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Gemini LLM pydantic v2 issue #15620

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Aug 24, 2024

Description

model was being overridden with the genai.GenerativeModel when it was supposed to be the model name (i.e., str). As a result Pydantic threw a validation error. This PR resolves this.

Fixes #15618

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@nerdai nerdai linked an issue Aug 24, 2024 that may be closed by this pull request
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 24, 2024
@nerdai nerdai merged commit 4a2cbec into main Aug 24, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/15618-bug-pydantic-issue-with-gemini-llm branch August 24, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Pydantic issue with Gemini LLM
1 participant