Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Colbert Rerank pydantic v2 issue #15619

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Aug 24, 2024

Description

The model param was not being set by default in the ColbertRerank class. As a result Pydantic V2 throws a validation error. This PR resolves this issue.

Fixes # (issue)

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 24, 2024
@nerdai nerdai requested a review from logan-markewich August 24, 2024 15:06
@nerdai nerdai merged commit 0b917fb into main Aug 24, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/fix-colbert-reranker branch August 24, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant