Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update llama-index-evaluation-tonic-validate #15613

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Aug 24, 2024

Description

This PR updates the tonic-validate dependency to use the latest version.

Close #12405

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 24, 2024
@nerdai
Copy link
Contributor Author

nerdai commented Aug 24, 2024

@chansonzhang: would you be able to test this branch to see if you get the errors you were referring to in the Feature Request Issue (#12405)?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 24, 2024
@nerdai
Copy link
Contributor Author

nerdai commented Aug 25, 2024

@chansonzhang — going to merge this PR and call it done. If the error still persists, please do submit a new issue and I'd be happy to investigate it then (hopefully its fixed with this tho!)

@nerdai nerdai merged commit 24687a1 into main Aug 25, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/12405-evaluation-tonic-validate-update branch August 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: llama-index-evaluation-tonic-validate need to be updated.
2 participants