Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve stray __pydantic_var__ Pydantic V2 issues in integrations/packs #15610

Merged
merged 3 commits into from
Aug 24, 2024

Conversation

nerdai
Copy link
Contributor

@nerdai nerdai commented Aug 24, 2024

Description

Some missed integrations and packs were missed when resolving __pydantic_var__ errors which can be resolved by moving the super().__init__(...) call before any private vars are set within a custom __init__() function of a BaseModel subclass.

Fixes # (issue)

Closes #15609

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 24, 2024
Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!! 🥰

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 24, 2024
@nerdai nerdai merged commit fa03a04 into main Aug 24, 2024
8 checks passed
@nerdai nerdai deleted the nerdai/stray-pydantic-private-var-issues branch August 24, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve all remaining __private_var__ pydantic v2 errors in integrations and packs
2 participants