Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix None type error when using Neo4jPropertyGraphStore #14957

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Fix None type error when using Neo4jPropertyGraphStore #14957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9edfe5c
fix None type error when using Neo4jPropertyGraphStore
yaqiangsun Jul 25, 2024
d7fccf2
vbump
logan-markewich Jul 25, 2024
1f0a740
linting
logan-markewich Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ...res/llama-index-graph-stores-neo4j/llama_index/graph_stores/neo4j/neo4j_property_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ class Neo4jPropertyGraphStore(PropertyGraphStore):
documents,
property_graph_store=graph_store,
)

# Close the neo4j connection explicitly.
graph_store.close()
```
"""

Expand Down Expand Up @@ -154,6 +157,9 @@ def __init__(
def client(self):
return self._driver

def close(self) -> None:
self._driver.close()

def refresh_schema(self) -> None:
"""Refresh the schema."""
node_query_results = self.structured_query(
Expand Down
2 changes: 1 addition & 1 deletion llama-index-integrations/graph_stores/llama-index-graph-stores-neo4j/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ exclude = ["**/BUILD"]
license = "MIT"
name = "llama-index-graph-stores-neo4j"
readme = "README.md"
version = "0.2.8"
version = "0.2.9"

[tool.poetry.dependencies]
python = ">=3.8.1,<4.0"
Expand Down
Loading