-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more filter type in query for relyt vector database #13512
base: main
Are you sure you want to change the base?
Conversation
@@ -59,9 +59,10 @@ class RelytVectorStore(BasePydanticVectorStore): | |||
_client: "PGVectoRs" = PrivateAttr() | |||
_collection_name: str = PrivateAttr() | |||
|
|||
def __init__(self, client: "PGVectoRs", collection_name: str) -> None: | |||
def __init__(self, client: "PGVectoRs", collection_name: str, enable_vector_index: bool) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this have a default option? Is there a reason to set this to false?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, thanks review again, i will later to add more feature for this , when this pr ready , will invite you to review again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think there's an example notebook in the docs we should update though?
@klaus-xiong small bump, can you update the example notebook and make sure it works? |
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahub
section in thepyproject.toml
and provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.toml
file of the package I am updating? (Except for thellama-index-core
package)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lint
to appease the lint gods