Add Question Generation module for evaluation. #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryjliu
reviewed
Apr 18, 2023
gpt_index/dataset_generation/base.py
Outdated
| from langchain.chat_models import ChatOpenAI | ||
| from llama_index.langchain_helpers.text_splitter import TokenTextSplitter | ||
|
|
||
| DEFAULT_QUESTION_GENERATION_PROMPT = """"Context information is below.\n" |
There was a problem hiding this comment.
you have four quote marks in the beginning (keep to 3)
| @@ -0,0 +1,5 @@ | |||
| """Dataset generation module.""" | |||
There was a problem hiding this comment.
instead of creating a new folder here, can you add the dataset generation module as part of evaluation folder? You can name the file dataset_generation.py.
And add DatasetGenerator to evaluation/__init__.py.
gpt_index/dataset_generation/base.py
Outdated
| ) | ||
|
|
||
| response = index.query( | ||
| f"You are a Teacher/ Professor. Your task is to setup \ |
There was a problem hiding this comment.
i'd abstract this into a constant string template (put as variable at the top of the file)
There was a problem hiding this comment.
but it uses the num_questions_per_chunk variable. probably I initialize it in the init?
gpt_index/dataset_generation/base.py
Outdated
| Generates questions for each document. | ||
| """ | ||
|
|
||
| def document_question_generator(chunks: List[str]) -> List[str]: |
There was a problem hiding this comment.
i wouldn't define this as a nested function. Define this on the class _document_question_generator
jerryjliu
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Added Question Generation module to DatasetGenerator for model evaluation and metrics. This module enables the evaluation of the model's performance in a QA system by generating questions and subsequently using the evaluation module for evaluating and proving metrics.
Thank you.