-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore outdated pack examples #11003
fix: ignore outdated pack examples #11003
Conversation
Shouldn't we just fix these examples? I'm also not 100% sure all of these are broken... will need to double check |
@logan-markewich yes that would be better to fix them. @thucpn tested them they are not working, so the idea is to disable them first so it's not blocking the next create-llama release. Then we could fix them later |
@logan-markewich but this PR should not be merged before run-llama/llama-hub#956 (this is disabling the non-working examples first in the old create-llama release) |
so please merge both PRs together, this one and run-llama/llama-hub#956 |
@marcusschiesser llama-hub is deprecated -- I don't really want to merge any more PRs over there :) Let me check out this branch and instead try to fix these packs |
@logan-markewich got it. Let us know if you need any help. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Description
Update
llama-index
to^0.10.6
make some examples run fail.I disable them for
create-llama
by rename fromexample.py
to_example.py
Also, make a small fix for
corrective-rag
pack (missing deps)Type of Change