Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore outdated pack examples #11003

Merged

Conversation

thucpn
Copy link
Contributor

@thucpn thucpn commented Feb 20, 2024

Description

Update llama-index to ^0.10.6 make some examples run fail.
I disable them for create-llama by rename from example.py to _example.py
Also, make a small fix for corrective-rag pack (missing deps)

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 20, 2024
@logan-markewich
Copy link
Collaborator

Shouldn't we just fix these examples? I'm also not 100% sure all of these are broken... will need to double check

@marcusschiesser
Copy link
Contributor

@logan-markewich yes that would be better to fix them. @thucpn tested them they are not working, so the idea is to disable them first so it's not blocking the next create-llama release. Then we could fix them later

@marcusschiesser
Copy link
Contributor

@logan-markewich but this PR should not be merged before run-llama/llama-hub#956 (this is disabling the non-working examples first in the old create-llama release)

@marcusschiesser
Copy link
Contributor

so please merge both PRs together, this one and run-llama/llama-hub#956

@logan-markewich
Copy link
Collaborator

@marcusschiesser llama-hub is deprecated -- I don't really want to merge any more PRs over there :)

Let me check out this branch and instead try to fix these packs

@marcusschiesser
Copy link
Contributor

@logan-markewich got it. Let us know if you need any help.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 6, 2024
@logan-markewich logan-markewich enabled auto-merge (squash) March 6, 2024 02:32
@logan-markewich logan-markewich merged commit 8f587fb into run-llama:main Mar 6, 2024
8 checks passed
Izukimat pushed a commit to Izukimat/llama_index that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants