fix: update maxRetries default and remove stale V1 extract examples#50
Open
eli-stewart wants to merge 8 commits into
Open
fix: update maxRetries default and remove stale V1 extract examples#50eli-stewart wants to merge 8 commits into
eli-stewart wants to merge 8 commits into
Conversation
- Update maxRetries default from 2 to 5 in client and test assertion - Delete stale V1 extract examples (extract_end_to_end.ts, extract_manual_polling.ts) that reference removed client.extraction API Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
logan-markewich
changed the base branch from
next
to
release-please--branches--main--changes--next--components--llama-cloud
logan-markewich
changed the base branch from
release-please--branches--main--changes--next--components--llama-cloud
to
next
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maxRetriesdefault from 2 to 5 in client constructor and JSDoc, plus matching test assertionexamples/extract/extract_end_to_end.tsandexamples/extract/extract_manual_polling.tswhich reference the removedclient.extractionV1 APINotes on scoped changes
Several other items were investigated but required no changes:
tests/e2e/extract.e2e.test.tsdoes not exist on thenextbranchsplit_end_to_end.tsandsplit_manual_polling.tsalready passcategoriesandsplitting_strategyat top-level, matching the currentSplitCreateParamstype. Noconfigurationwrapper exists in the split types.src/resources/extract.ts): This file has norun()orwaitForCompletion()methods, so no JSDoc to update. The V1extraction/files have JSDoc that correctly matches V1 types and are already marked@deprecated.Test plan
npx jest tests/index.test.tspasses (51/51)./scripts/lint(build) completes with no TS errors🤖 Generated with Claude Code