This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Simple short-form Self-RAG Pack #907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@anoopshrma could you please review this? |
Hey! Sure will do by tomorrow. Currently away from machine. |
jerryjliu
approved these changes
Feb 2, 2024
| from llama_cpp import Llama # noqa: F401 | ||
| except ImportError: | ||
| raise ImportError(_IMPORT_ERROR_MSG) | ||
| self.llm = Llama(model_path=model_path, verbose=verbose, **model_kwargs) |
There was a problem hiding this comment.
we do have a llamacpp wrapper in llamaindex. out of curiosity is there a reason you are using the llama_cpp lib directly? (it's fine either way, just curious)
There was a problem hiding this comment.
oh nvm seems like its for logprobs
anoopshrma
approved these changes
Feb 2, 2024
|
Hey @jerryjliu , since all the comments have been resolved. Can I go ahead and merge it or do you want to take another look. |
jerryjliu
approved these changes
Feb 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simple short-form Self-RAG implementation using llama_cpp adapted from the author's code
Paper: https://arxiv.org/abs/2310.11511
Model: https://huggingface.co/m4r1/selfrag_llama2_7b-GGUF
Fixes #8502 (run-llama/llama_index#8502)
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods