Skip to content
This repository was archived by the owner on Mar 1, 2024. It is now read-only.

feat(GenomeAnnotationReader): Reader of NCBI's genome annotetion at nuccore databases #662

Closed
wants to merge 0 commits into from

Conversation

acpguedes
Copy link

Description

I included a new reader to read NCBI's genome annotation. It receive a species name and search the organism against NCBI's nuccore databases and return a array of genome annotation of this species to multiple strains.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • [ x] New Loader/Tool
  • Bug fix / Smaller change
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • [ x] I stared at the code and made sure it makes sense

Suggested Checklist:

  • [ x] I have added a library.json file if a new loader/tool was added
  • [ x] I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ x] I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [ x] New and existing unit tests pass locally with my changes
  • [ x] I ran make format; make lint to appease the lint gods

image

@anoopshrma
Copy link
Collaborator

Seems there's still conflict! Could you take a look at this also @acpguedes

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants