This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Refactor load_data for consistent sheet handling and cleaner code #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure sheet_name is always treated as a list to maintain consistent behavior - Remove redundant parentheses from self._row_joiner - Rename variable for clarity (from 'keys' to 'sheet_names') - Update function docstring to reflect changes
|
Hi @jerryjliu, |
|
@guyy1232 sorry for the delay! reviewing now |
jerryjliu
suggested changes
Sep 7, 2023
jerryjliu
approved these changes
Sep 7, 2023
Thank you for reviewing! |
added 2 commits
September 7, 2023 13:31
guyyanko
commented
Sep 12, 2023
|
nice one |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue in the
load_datafunction when reading a specific sheet from an Excel file and performs code simplification.Issues Addressed:
self._row_joiner.Changes Made:
sheet_nameis processed always to treat it as a list, ensuring consistent behavior across single or multiple sheet name inputs.self._row_joinerfor cleaner code.keystosheet_namesfor better clarity.By implementing these changes, the function is now more robust and can handle different input scenarios effectively. Additionally, the code has been streamlined for better readability.