identifiers: Make backwards-compatible by default and disallow NUL byte
#2009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
It now accepts even non-spec compliant user IDs, due to a clarification in the spec. Removes the `compat-user-id` cargo feature.
zecakeh
force-pushed
the
zecakeh/ids-compat
branch
from
4de10a1 to
851f522
Compare
jplatte
approved these changes
Jan 31, 2025
Due to a clarification in the spec.
zecakeh
force-pushed
the
zecakeh/ids-compat
branch
from
851f522 to
9bd4d17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a clarification in the spec.
Removes the
compat-user-idcargo feature.Part of #2001.