Skip to content

core: Improve spurious key ignoring logic #22262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

core: Improve spurious key ignoring logic #22262

wants to merge 1 commit into from
+19 −5

Conversation

@SuchAFuriousDeath
Copy link
Contributor

@SuchAFuriousDeath SuchAFuriousDeath commented Nov 17, 2025

Fixes #22046

@kjarosh kjarosh self-requested a review November 17, 2025 13:21
@Lord-McSweeney Lord-McSweeney added A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already) labels Nov 17, 2025
@SuchAFuriousDeath SuchAFuriousDeath force-pushed the spurious-keys branch 2 times, most recently from 92b1a38 to a20b356 Compare November 20, 2025 14:20
@kjarosh
Copy link
Member

kjarosh commented Nov 20, 2025

Could you add a test for this specific case from the issue? (Also we need to make sure other tests pass)

@SuchAFuriousDeath SuchAFuriousDeath marked this pull request as draft November 28, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjarosh kjarosh Awaiting requested review from kjarosh

Assignees

No one assigned

Labels

A-core Area: Core player, where no other category fits T-fix Type: Bug fix (in something that's supposed to work already)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

key-up works incorrectly in combination with shift

3 participants

@SuchAFuriousDeath @kjarosh @Lord-McSweeney