ci: Fix failing doctests and run them in CI #17716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinnerbone
approved these changes
Sep 4, 2024
torokati44
reviewed
Sep 4, 2024
torokati44
reviewed
Sep 4, 2024
torokati44
reviewed
Sep 4, 2024
torokati44
approved these changes
Sep 4, 2024
kjarosh
force-pushed
the
doctests
branch
2 times, most recently
from
f680654
to
94544d6
Compare
The syntax used for modifying an environment variable did nothing on Windows (PowerShell).
The environment variable FEATURES sets the set of features used while testing, that makes it possible to have just one step and prevent code duplication.
Unfortunately nextest does not support doc tests yet, they need to be run using cargo test.
|
Thank you! |
kjarosh
removed
the
waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately nextest does not support doctests yet (nextest-rs/nextest#16), they need to be run using cargo test.
This adds ~10s on Linux and macOS and ~15s on Windows.