Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: snowflake integrations tests to use keypair instead of password #5684

Merged
merged 1 commit into from
Apr 2, 2025

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Apr 2, 2025

Description

  • Use keypair instead of Password for Snowflake Integration Tests since Password based authentication Is getting deprecated.
  • Removed SNOWFLAKE_KEYPAIR_ENCRYPTED_INTEGRATION_TEST_CREDENTIALS based test, as it is redundant now. We are by default using encrypted key pair credentials.

Linear Ticket

  • Resolves WAR-471

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.91%. Comparing base (3290794) to head (87282b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5684      +/-   ##
==========================================
- Coverage   76.92%   76.91%   -0.02%     
==========================================
  Files         475      475              
  Lines       65275    65275              
==========================================
- Hits        50215    50205      -10     
- Misses      12310    12318       +8     
- Partials     2750     2752       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@achettyiitr achettyiitr merged commit 3ed7a11 into master Apr 2, 2025
63 checks passed
@achettyiitr achettyiitr deleted the chore.snowflake-integration-keypair-tests branch April 2, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants