docs(Documentation): Minor update to contribution guide #731
+16
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xquark
reviewed
Jan 21, 2026
rdimaio
reviewed
Jan 24, 2026
voetberg
reviewed
Feb 4, 2026
| ### 5. Watch the Pull Request for reviews | ||
|
|
||
| Watch the pull request for comments and reviews. We expect that all continuous integration | ||
| test-cases run through, if they do not either close the pull request and re-submit |
Contributor
There was a problem hiding this comment.
I find the wording here a little confusing. May I suggest:
We expect all continuous integration tests to be passing.
If they fail, either fix your changes, or close the pull request and re-submit at a later date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #730