-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix after_commit for Rails 6 #482
Conversation
Can this be merged? |
Still waiting for it... Is the only thing that prevents me to updating to Rails 6. :( |
@jhawthorn @sevenseacat Can one of the maintainers look at this? Thanks in advance! |
FWIW: For whatever reason, when I upgraded to Paranoia 2.4.2, this change didn't come along with it. But when I put |
There's been no release since this patch was merged - I don't have access to do that on Rubygems, unfortunately. |
@sevenseacat who has this access to make this happen? |
@jhawthorn can you make a release with these changes? |
This change was included in a patch yet it is actually |
hmm, according to the test suite, all tests pass with 5.2 and 5.1 if there is a bug, we don't know about it. |
Trigger after_commit on destroy to work with rails 6
This addresses #478