Added association not soft destroyed validator #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardmp
changed the title
|
Why the merge commit in e3eeb53? |
|
Looks like 51f9541 occurred in #385, yet @jhawthorn hasn't rebased. So I'll take yours :) |
|
@BenMorganIO because I first edited the README directly through GitHub, and then fixed the test warnings but forgot to pull first ;) |
BenMorganIO
reviewed
Mar 7, 2017
test/paranoia_test.rb
Outdated
| validates :parent_model, association_not_soft_destroyed: true | ||
| end | ||
|
|
||
|
|
|
@edwardmp awesome. Could you add this to the Changelog using the same format as in 2.2.1 and see if you can remove the merge commit? It's fine if you can't, they're tricky things merge commits. Thanks for all your work on getting this guy in!!! |
edwardmp
force-pushed
the
AssociationNotSoftDestroyedValidator
branch
from
e3eeb53
to
fc16137
Compare
|
@BenMorganIO all fixed! |
edwardmp
force-pushed
the
AssociationNotSoftDestroyedValidator
branch
2 times, most recently
from
5dd1ea1
to
fbd117f
Compare
edwardmp
force-pushed
the
AssociationNotSoftDestroyedValidator
branch
from
fbd117f
to
d366099
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #380.
While we're at it I also included some changes so the following warning doesn't show up anymore:
Use assert_nil if expecting nil from [..]. This will fail in MT6.