Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record not touched on soft destroy #296

Closed
jeffblake opened this issue Jan 9, 2016 · 5 comments
Closed

Record not touched on soft destroy #296

jeffblake opened this issue Jan 9, 2016 · 5 comments
Assignees
@BenMorganIO
Labels
bug

Comments

@jeffblake
Copy link

I could have sworn this worked as expected (and by paranoia design) that a records updated_at attribute gets touched when calling destroy. However, thats not happening. I looked at the code, and see a touch method call under the restore method, but not the destroy method. Am I missing something?
@ccleung
Copy link

ccleung commented Feb 9, 2016

I'm noticing this issue too, i think it might have broke with this commit? b2b8d19

It updated the updated_at column in 2.1.3, no longer in 2.1.4

@rbr rbr mentioned this issue Feb 21, 2016
Closed
john-griffin pushed a commit to john-griffin/paranoia that referenced this issue May 13, 2016
@rbr @john-griffin
Touch record on paranoia-destroy. Fixes rubysherpas#296
23d488d 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
@cfeckardt cfeckardt mentioned this issue Jul 5, 2016
Open
@jeffblake
Copy link
Author

Bump

@jeffblake
Copy link
Author

Hi Ben,

Hoping we can see this merged in the near future. Thanks :)

@BenMorganIO
Copy link
Collaborator

@jeffblake alright, I'll take some time to get #311 merged on in tonight.

@jeffblake
Copy link
Author

@BenMorganIO thanks ben!

@BenMorganIO BenMorganIO self-assigned this Jan 20, 2017
rbr added a commit to rbr/paranoia that referenced this issue Jan 28, 2017
@rbr
Touch record on paranoia-destroy. Fixes rubysherpas#296
eca3256 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra
query.
rbr pushed a commit to rbr/paranoia that referenced this issue Jan 28, 2017
Touch record on paranoia-destroy. Fixes rubysherpas#296
aa1c1de 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
rbr pushed a commit to rbr/paranoia that referenced this issue Jan 28, 2017
Touch record on paranoia-destroy. Fixes rubysherpas#296
7eaff42 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
@rbr rbr mentioned this issue Jan 28, 2017
Merged
BenMorganIO added a commit that referenced this issue Feb 4, 2017
@BenMorganIO
Merge pull request #377 from rbr/touch_on_destroy
c9728e1 
Touch record on paranoia-destroy. Fixes #296
thromera added a commit to thromera/paranoia that referenced this issue Feb 7, 2017
@thromera
Fixes a problem of ambiguous table names when using only_deleted meth…
3b33272 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
thromera pushed a commit to thromera/paranoia that referenced this issue Feb 7, 2017
Touch record on paranoia-destroy. Fixes rubysherpas#296
4128c20 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
thromera added a commit to thromera/paranoia that referenced this issue Feb 7, 2017
@thromera
Fixes a problem of ambiguous table names when using only_deleted meth…
a756b20 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
thromera added a commit to thromera/paranoia that referenced this issue Feb 7, 2017
@thromera
Fixes a problem of ambiguous table names when using only_deleted meth…
9a89efa 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
thromera added a commit to thromera/paranoia that referenced this issue Feb 7, 2017
@thromera
Fixes a problem of ambiguous table names when using only_deleted meth…
1ebd917 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
thromera added a commit to thromera/paranoia that referenced this issue Feb 14, 2017
@thromera
Fixes a problem of ambiguous table names when using only_deleted meth…
2024303 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
karunkumar1ly pushed a commit to edcast/paranoia that referenced this issue Feb 6, 2024
@arun-zc
Touch record on paranoia-destroy. Fixes rubysherpas#296
78f4c2d 
Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
karunkumar1ly pushed a commit to edcast/paranoia that referenced this issue Feb 6, 2024
@thromera @arun-zc
Fixes a problem of ambiguous table names when using only_deleted meth…
1929a9d 
…od and joining tables that have a scope on `with_deleted`

Update homepage in gemspec

The homepage is supposed to be where you can find the code. It is displayed on rubygems.org page. Currently it will redirect you back to the same page. Should point at this github repo.

Update README to use proper version for Rails 5

Version 2.2.0

Ignore failures from all jruby's on travis

Add explicit language about dependent: :destroy

Update CHANGELOG.md

update ruby and rails versions

Use ActiveSupport.on_load to correctly re-open ActiveRecord::Base. rubysherpas#335

Touch record on paranoia-destroy. Fixes rubysherpas#296

Touch record on destroy by leveraging the paranoia_destroy_attributes.
Applied the same to the restore-method as this eliminates the extra query.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenMorganIO BenMorganIO

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffblake @BenMorganIO @ccleung