Skip to content

Conversation

@tkdn
Copy link
Contributor

@tkdn tkdn commented Jan 23, 2023

@postmodern
Copy link
Member

This might confuse people who are not familiar with Rails LTS, since Rails LTS has released versions which stock Rails has not. Could you add (rails LTS) after the 5.x versions in the description text, and a # rails LTS commend after the ~> 5.x, >= 5.x.y.z lines?

@postmodern postmodern requested a review from reedloden January 23, 2023 08:22
@tkdn
Copy link
Contributor Author

tkdn commented Jan 23, 2023

@postmodern
Thanks for the review. I've added comments for rails (LTS). 50d6e1d

Copy link
Member

@reedloden reedloden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this!

@reedloden reedloden merged commit c9cf6ea into rubysec:master Jan 23, 2023
@rea-jonpad
Copy link

This might confuse people who are not familiar with Rails LTS, since Rails LTS has released versions which stock Rails has not. Could you add (rails LTS) after the 5.x versions in the description text, and a # rails LTS commend after the ~> 5.x, >= 5.x.y.z lines?

Because of the way downstream systems such as bundler-audit use the YAML, the # rails LTS comment appended after the ~> 5.x, >= 5.x.y.z lines is effectively ignored by the YAML parser.

Then bundler-audit recommends upgrading to the Rails LTS gem, which is a commercial offering, and not available without a license, username & password.

I realize that in some ways, this is bundler-audit's problem. But with the "# (Rails LTS)" effectively being stripped out by the YAML parser, bundler-audit has no way to identify such gems as being restricted, and not widely available, however it still recommends it as a fix.

Perhaps fixed versions from external third parties could have additional metadata and be marked as such?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants