Add --no-exit-on-warn flag that exits with 0 even when vulnerable #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be more useful when 0 status will be returned in case when no solutions presents yet |
|
@MC-Squared You forgot to add specs for your new feature. |
|
Was going to suggest just appending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I would like to run bundler-audit as part of our CI builds that test every branch/PR, however I do not want vulnerabilities to cause the build to be considered a failure.
Obviously, this can be achieved in bash but Brakeman, which we also run, provides a
--no-exit-on-warnflag for this purpose.Fix
Added a
--no-exit-on-warnflag that causes the CLI to exit with 0, even if vulnerabilities are found.Error cases, such as update failing, should be unaffected by this change.