This repository was archived by the owner on Aug 26, 2023. It is now read-only.
Use Nokogiri with line numbers#130
Closed
fulldecent wants to merge 1 commit intorubys:masterfrom
fulldecent:patch-2
Closed
Use Nokogiri with line numbers#130fulldecent wants to merge 1 commit intorubys:masterfrom fulldecent:patch-2
fulldecent wants to merge 1 commit intorubys:masterfrom
fulldecent:patch-2
Conversation
This was referenced Sep 5, 2019
Contributor
Author
|
Ready for review. |
Collaborator
stevecheckoway
left a comment
stevecheckoway
left a comment
There was a problem hiding this comment.
I don't believe it's reasonable to make Nokogumbo depend on some random branch of Nokogiri I have. I think we just have to wait for sparklemotion/nokogiri#1918 to land.
Collaborator
|
Oh, a new branch here. Hmm. I'm not sure I have an informed opinion on that. |
Contributor
Author
|
This issue (downstream) has been open for three years, so having a new branch here (which does not need to be maintained) is just some progress forward. |
|
This has be included in nokogiri v1.11.0.rc1 🎉 |
Collaborator
|
As noted by @sunny above, Nokogiri v1.11.0 and later support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to use the PR at sparklemotion/nokogiri#1918 today.
Then development effort can continue using line numbers. This is a path forward to allow html-proofer to work with HTML5.
Recommending that this PR be updated to merge into a new branch here, rather than master.