This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
Support Linux PowerPC64 LE platform #296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runlevel5
changed the title
runlevel5
force-pushed
the
patch-1
branch
4 times, most recently
from
f9968de
to
0a3b2cf
Compare
runlevel5
commented
Apr 28, 2020
Comment on lines
+162
to
+159
| FileUtils.rm_f(File.expand_path("../../../vendor/depot_tools/gn", __FILE__)) | ||
| FileUtils.symlink(gn_filepath, File.expand_path("../../../vendor/depot_tools/gn", __FILE__), force: true) |
There was a problem hiding this comment.
The bundled depot_tools/gn is a binary for amd64. We replace that with our gn
|
Our efforts are focused on libv8-node and thus libv8 is unmaintained, so I'll close this. Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds support for building libv8 for linux ppc64le
Changes
Pending Issues