Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

[WIP] Upgrade to upstream v8 6.7 #258

Merged
merged 15 commits into from
Jul 6, 2018
Merged

[WIP] Upgrade to upstream v8 6.7 #258

merged 15 commits into from
Jul 6, 2018

Conversation

ignisf
Copy link
Collaborator

@ignisf ignisf commented Jun 21, 2018

Fixes #255
Fixes #228
Fixes rubyjs/mini_racer#85

@ignisf ignisf changed the title Upgrade to upstream v8 6.7 [WIP] Upgrade to upstream v8 6.7 Jun 21, 2018
@ignisf ignisf force-pushed the 6.7 branch 6 times, most recently from d6376e1 to 827ba25 Compare June 22, 2018 10:43
@ignisf ignisf force-pushed the 6.7 branch 2 times, most recently from db1b98d to b48199d Compare June 22, 2018 19:32
@SamSaffron
Copy link
Contributor

@ignisf any chance for a release this week, super keep to bump mini_racer due to segfault etc...

@ignisf
Copy link
Collaborator Author

ignisf commented Jul 5, 2018

@SamSaffron, I've been trying to get the library to compile for ARM, and have not been able to. If we release now, we're losing support for ARM, FreeBSD and Alpine Linux...

Now, I am fine with that, considering this PR nukes all the functionality that made it possible to compile for those platforms with GYP, however maybe mini_racer should have a version with the segfault-related fixes that depends on the older more portable V8 version?

@SamSaffron
Copy link
Contributor

OK, no problem ❤️ ... 0.2.0 is now out and it is cross compatible with 6.3 and up

So this gives us some time to get ARM support (though for Discourse I am going to push the libv8 dep explicitly to 6.7)

@ignisf
Copy link
Collaborator Author

ignisf commented Jul 6, 2018

yes, awesome!

@ignisf ignisf merged commit a89f787 into master Jul 6, 2018
@ignisf
Copy link
Collaborator Author

ignisf commented Jul 6, 2018

it's live 🎉

@SamSaffron
Copy link
Contributor

SamSaffron commented Jul 8, 2018 via email

@nightpool nightpool deleted the 6.7 branch July 20, 2020 22:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants