-
Notifications
You must be signed in to change notification settings - Fork 121
[WIP] Upgrade to upstream v8 6.7 #258
Conversation
d6376e1
to
827ba25
Compare
db1b98d
to
b48199d
Compare
@ignisf any chance for a release this week, super keep to bump mini_racer due to segfault etc... |
@SamSaffron, I've been trying to get the library to compile for ARM, and have not been able to. If we release now, we're losing support for ARM, FreeBSD and Alpine Linux... Now, I am fine with that, considering this PR nukes all the functionality that made it possible to compile for those platforms with GYP, however maybe mini_racer should have a version with the segfault-related fixes that depends on the older more portable V8 version? |
OK, no problem ❤️ ... 0.2.0 is now out and it is cross compatible with 6.3 and up So this gives us some time to get ARM support (though for Discourse I am going to push the libv8 dep explicitly to 6.7) |
yes, awesome! |
it's live 🎉 |
Yay!!!
Going to upgrade Discourse on Monday!
…On Fri, 6 Jul 2018 at 11:14 pm, Petko Bordjukov ***@***.***> wrote:
it's live 🎉
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#258 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAAUXUhloZOXkY84KM2rC2E0QmVOvrNxks5uD2LPgaJpZM4UyOJm>
.
|
Fixes #255
Fixes #228
Fixes rubyjs/mini_racer#85