Skip to content
This repository was archived by the owner on Jul 31, 2023. It is now read-only.

Conversation

@neurolag
Copy link

Currently, yarn run build won't run through if packages/language-server-ruby/dist directory doesn't exist.
Changes made in this PR will add a piece of code to fix this issue.

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

@wingrunr21
Copy link
Collaborator

The change to the esbuild config should not be necessary per the docs

Is this due to the lerna concurrency and the symlink steps into the plugin folder?

@wingrunr21 wingrunr21 added the need-more-info Awaiting information from author label Apr 5, 2022
@neurolag
Copy link
Author

neurolag commented Apr 5, 2022

The change to the esbuild config should not be necessary per the docs

Is this due to the lerna concurrency and the symlink steps into the plugin folder?

The esbuild-settings use outfile rather than outdir. Looks like the output directory isn't created automatically for the outfile setting.
If this is allowed by esbuild, specifying both outfile and outdir might be another solution.

Apart from that, lernas concurrency didn't cause any issue with esbuild but rather with the tree-sitter portion of the project (the .wasm-file can't be found - probably because it gets deleted by concurrent lerna-tasks). Thus, I changed the lerna-settings to run only one task at a time.

@hayesr
Copy link
Contributor

hayesr commented May 29, 2022

I just tried this and was able to get it to build and run. I did run into some test problems, but maybe those should be for a different PR.

@github-actions
Copy link

This PR has not had activity for 30 days. It will be automatically closed in 30 days.

@github-actions github-actions bot added the stale label Sep 27, 2022
@github-actions github-actions bot closed this Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

need-more-info Awaiting information from author stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants