Spike of community resource browsing #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are still a lot of problems with them
The community resources were being filtered out because they don't use service areas the same way as asks and offers. This refactors the scope stuff for filtering by service areas so that it works for community resources as well as asks and offers Co-authored-by: connieh1 <connie2630a@gmail.com>
h-m-m
force-pushed
the
hmm/spike-of-community-resources
branch
from
6a55169
to
7ce313f
Compare
h-m-m
force-pushed
the
hmm/spike-of-community-resources
branch
from
7ce313f
to
f888f85
Compare
h-m-m
commented
Jul 5, 2021
h-m-m
commented
Jul 5, 2021
h-m-m
commented
Jul 5, 2021
Comment on lines
+59
to
+62
| # TODO: This is a hack that makes things work for now | ||
| # The test creates a contact method that will match this | ||
| # and the dev db seeding creates a couple, too | ||
| ContactMethod.method_name('call').last |
There was a problem hiding this comment.
Is there some way I can fix this in its own PR? In other codebases I work in, this whole workflow is something I'd hide behind a feature flag so I can get this PR out first, and then get the contact methods for community resources working in a separate PR. I could also try to fix it here, especially if anyone's willing to help me with it. Please let me know
There was a problem hiding this comment.
Added an issue for this at #986
h-m-m
force-pushed
the
hmm/spike-of-community-resources
branch
from
a3eb745
to
9c7f9ae
Compare
h-m-m
changed the title
h-m-m
commented
Jul 10, 2021
h-m-m
commented
Jul 10, 2021
Comment on lines
+65
to
+75
| def type | ||
| "Community Resource" | ||
| end | ||
|
|
||
| def inexhaustible | ||
| true | ||
| end | ||
|
|
||
| def urgency_level_id | ||
| UrgencyLevel::TYPES.last.id | ||
| end |
There was a problem hiding this comment.
@exbinary mentioned that these don't feel like actual attributes, behaviors, or properties of a community resource, and so they might be better off in an abstraction or interface class that turns community resources into something blueprint-able
h-m-m
commented
Jul 10, 2021
Comment on lines
+87
to
+92
| "description" => "Food for the revolution", | ||
| "inexhaustible" => true, | ||
| "location" => nil, | ||
| "match_path" => nil, | ||
| "name" => "Free breakfast for School Children Program", | ||
| "person" => nil, |
There was a problem hiding this comment.
@exbinary pointed out how hashes like this to test blobs of JSON are fragile since small changes can then require lots of edits
added 3 commits
August 14, 2021 12:20
This requires a service area and category for every saved community resource Cons: * makes our code less flexible, more brittle because it hardens dependencies between the models * may frustrate users (but honestly, we don't know without finding some users and asking them) Pros: * easy to remove if we change our mind (harder to add later once invalid data already exists) * very little code to implement and maintain * requires less rethinking of assumptions for Map and List browser Vue code
h-m-m
commented
Aug 28, 2021
Comment on lines
+20
to
+23
| # We're not sure if we need or want these validations. Adding them now assuming it will be easier to remove them later than the other way around | ||
| validates :service_areas, presence: true | ||
| validates_associated :service_areas | ||
| validates :tag_list, presence: true |
There was a problem hiding this comment.
- TODO: fix request specs that now flunk validation checks
h-m-m
force-pushed
the
hmm/spike-of-community-resources
branch
from
d03455d
to
e898c66
Compare
also destroy relevant join table records when destroying a community resource
h-m-m
force-pushed
the
hmm/spike-of-community-resources
branch
from
e898c66
to
cd5aa11
Compare
Conflicts: * app/javascript/pages/browse/MapBrowser.vue
The introduction of community resources to /contributions means that `.id` is not guaranteed to be unique across all types.
This was referenced Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This addresses some of #882 and #880. Specifically, it
What
This updates our filtering classes so they can handle community resources.
The contact method logic is not implemented correctly, see inline notes below
There are certainly other aspects of this which are incomplete
How
Testing
Next Steps
Outstanding Questions, Concerns and Other Notes
Accessibility
Security
Meta
Pre-Merge Checklist