806 : the navbar is not displayed correctly

[vurtn]

Sorry for my english.

Why

The navbar is always hidden on asks/new and offers/new (#806).

What

• Display the navbar if the setting is on

How

The problem is that the navigation bar is still hidden because the option in settings is not used. We need to hide the navbar if the boolean is false like in other controllers.

Testing

I don't know what to add.

Next Steps

Unknown.

Outstanding Questions, Concerns and Other Notes

Not seem to be concerned.

Accessibility

Not seem to be concerned.

Security

Not seem to be concerned.

Meta

Not seem to be concerned.

Pre-Merge Checklist

I think the reviewer will check this so i let it empty.

• Security & accessibility have been considered
• Tests have been added, or an explanation has been given why the features cannot be tested
• Documentation and comments have been added to the codebase where required
• Entry added to CHANGELOG.md if appropriate
• Outstanding questions and concerns have been resolved
• Any next steps have been turned into Issues or Discussions as appropriate

[h-m-m]

Hi, @gamecat2d! Thanks for helping us out with this project! I'm so happy to see contributions from new people.

The changes you've made look okay to me. Since you say you're not sure what tests to add, maybe I could help with some suggestions.

Maybe we can add new files to spec/requests folder, one for each controller, and then add a test that

• sets the system preference
• requests the page
• asserts that the response.body does or does not have the nav bar

If you haven't written a test like this before, I'm happy to provide examples. Please let me know what you think

[h-m-m]

An update, @gamecat2d:

I talked to @exbinary about this, who pointed out that your question here about testing and your questions in #770 raised some interesting issues we hadn't discussed before. We both agree that we should accept this PR without worrying about tests yet and then add some info to a new issue, #967, to clarify requirements for how the nav bar could work

If you want to, feel free to request an invite to our Slack at https://rubyforgood.herokuapp.com/ and join us in the #mutualaid channel. We'd be happy to give you more background into what's happening in the code here and answer any questions you have that aren't covered in #967. You're also welcome to continue posting here on GitHub if that's more comfortable for you. Either way is fine — I wanted to have the option.