Rubocop rules related to empty lines and trailing whitespace #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solebared
changed the title
24 tasks
solebared
force-pushed
the
rubocop/single-line-methods
branch
2 times, most recently
from
00e1619
to
2dad583
Compare
solebared
force-pushed
the
rubocop/whitespace
branch
from
110d58c
to
2ee66d4
Compare
solebared
force-pushed
the
rubocop/single-line-methods
branch
from
2dad583
to
d422b9b
Compare
solebared
force-pushed
the
rubocop/whitespace
branch
from
2ee66d4
to
f4082a4
Compare
solebared
force-pushed
the
rubocop/single-line-methods
branch
from
d422b9b
to
c7f8135
Compare
solebared
force-pushed
the
rubocop/whitespace
branch
from
f4082a4
to
2b73b67
Compare
solebared
force-pushed
the
rubocop/single-line-methods
branch
from
c7f8135
to
c1dcfcc
Compare
solebared
force-pushed
the
rubocop/whitespace
branch
from
2b73b67
to
d7a9eb2
Compare
h-m-m
approved these changes
May 15, 2021
solebared
force-pushed
the
rubocop/single-line-methods
branch
from
c1dcfcc
to
ae9cdf2
Compare
Standard recommends the `final_newline` style: https://docs.rubocop.org/rubocop/cops_layout.html#layouttrailingemptylines
Accept Standard recommendations and fix violations for: * Layout/EmptyComment * Layout/EmptyLineAfterMagicComment * Layout/EmptyLinesAroundAccessModifier * Layout/EmptyLinesAroundArguments * Layout/EmptyLinesAroundClassBody * Layout/EmptyLinesAroundModuleBody
solebared
force-pushed
the
rubocop/whitespace
branch
from
d7a9eb2
to
829847c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Building on #935, fixes violations of several whitespace related rules.
What
See commits for list of rules tackled.
One rule worth mentioning: Standard enforces the
final_newlinestyle for theLayout/TrailingEmptyLinesrule.In accepting this, which i recommend, authors will need to configure their editors to follow this convention.
Here's an article describing how to configure this in common editors.
Testing
Relying on our existing suite to catch any regressions.
Next Steps
?
Outstanding Questions, Concerns and Other Notes
Really curious the team's thoughts on this.
Pre-Merge Checklist