Rubocop trailing comma rules #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
solebared
force-pushed
the
rubocop/layout
branch
from
a31a98c
to
a7018e3
Compare
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
bdca636
to
8df8a1c
Compare
solebared
changed the title
solebared
force-pushed
the
rubocop/layout
branch
from
a7018e3
to
0cb93b9
Compare
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
8df8a1c
to
b460c0d
Compare
solebared
force-pushed
the
rubocop/layout
branch
from
0cb93b9
to
31594be
Compare
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
b460c0d
to
4631712
Compare
solebared
force-pushed
the
rubocop/layout
branch
from
31594be
to
0a48374
Compare
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
4631712
to
2c6aa04
Compare
solebared
force-pushed
the
rubocop/layout
branch
from
0a48374
to
1e368d9
Compare
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
2c6aa04
to
f744eb8
Compare
svileshina
approved these changes
May 1, 2021
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
f744eb8
to
b0cb7f4
Compare
Standard used to allow trailing commas but switched to disallowing them everywhere: standardrb/standard#159 I've admittedly been a long-time fan of trailing commas but was convinced by the discussion linked from the issue above: fables-tales/rubyfmt#154
See discussion in previous comments.
See discussion in antepenultimate commit
solebared
force-pushed
the
rubocop/trailing-commas
branch
from
b0cb7f4
to
2324fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Building on #935, enables rules related to trailing commas, fixing corresponding violations.
What
Standard used to allow trailing commas but switched to disallowing them everywhere: standardrb/standard#159
I've admittedly been a long-time fan of trailing commas but was convinced by the discussion linked from the issue above: fables-tales/rubyfmt#154
Testing
Relying on our existing suite to catch any regressions.
Next Steps
?
Outstanding Questions, Concerns and Other Notes
Not sure if any others on the core team are/were fans of trailing commas?
I'm curious how this lands?
Pre-Merge Checklist