Fix bug on landing page where custom text was being ignored #780

solebared · 2020-10-12T19:44:48Z

Why

Fixes #769 where custom landing page text was being ignored.

All new features have been described in the pull request
Security & accessibility have been considered
All outstanding questions and concerns have been resolved
Any next steps that seem like good ideas have been created as issues for future discussion & implementation
High quality tests have been added, or an explanation has been given why the features cannot be tested
Entry added to CHANGELOG.md if appropriate

Tracked down to a mismatch between snake_case params from rails and camelCase props on the erb template.

This could only have been caught by an end-to-end test, which we don't have yet :(

Co-authored-by: maebeale meabeale@gmail.com

Co-authored-by: maebeale <maebeale@gmail.com>

solebared assigned maebeale Oct 12, 2020

solebared force-pushed the fix-landing-page-custom-text branch from 9854c38 to d12fea6 Compare October 12, 2020 19:48

maebeale approved these changes Oct 12, 2020

View reviewed changes

Fix prop case in landing_page.html.erb to match Orientation.vue

b6bb617

Co-authored-by: maebeale <maebeale@gmail.com>

solebared force-pushed the fix-landing-page-custom-text branch from d12fea6 to b6bb617 Compare October 12, 2020 20:02

solebared merged commit 8000e1c into main Oct 13, 2020

solebared deleted the fix-landing-page-custom-text branch October 13, 2020 16:05