Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In a docker development environment, the test are run using the app
service - IE the use the same "image" as the running application - via
bin/dev/test. This service is no longer needed.
Resolves #739
Pre-Merge Checklist
All these boxes should be checked off before any pull request is merged!
How
bin/dev/test
reuses theapp
service's image to spin up a container in which the tests are run. Forrspec
, the spec_helper already specifies that the application will run in thetest
environment, rather than the default.Testing
bin/dev/test
should still run the test suiteNext Steps
It might be nice to provide an interface to allow the developer to run a specific, or subset, of examples/specs in the test suite. I know this fuctionality exists via RSpec, but the
bin/dev/test
script currently assumes that you want to run the Rails and JavaScript test suites - IE test the whole application.