bug-5152 Adds test coverage to transfer export, which already include… #5202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dorner
requested changes
May 23, 2025
| let(:unused_item) { create(:item, name: "Unused Item", organization: organization) } | ||
| let(:generated_csv_data) do | ||
| # Force unused_item to be created first | ||
| unused_item |
Collaborator
There was a problem hiding this comment.
Would it be simpler to replace let with let! on line 105, and then you don't have to do this? Same below.
Contributor
Author
There was a problem hiding this comment.
Good point and yes, that works -- definitely still re-learning Rspec conventions.
dorner
approved these changes
May 30, 2025
Collaborator
|
Thanks! |
Contributor
|
@bsbonus: Your PR |
GiovannyCordeiro
pushed a commit
to GiovannyCordeiro/human-essentials
that referenced
this pull request
Jun 6, 2025
rubyforgood#5202) * bug-5152 Adds test coverage to transfer export, which already includes inactive items * bug-5152 cleans up rspec file to use let
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s inactive items
Checklist:
X I have performed a self-review of my own code,
X I have commented my code, particularly in hard-to-understand areas,
X I have made corresponding changes to the documentation,
X I have added tests that prove my fix is effective or that my feature works,
X New and existing unit tests pass locally with my changes ("bundle exec rake"),
X Title include "WIP" if work is in progress.
X I acknowledge that I will not force push my branch once reviews have started.
Resolves #5152 - partially, see main thread
Description
Adds missing test coverage to existing export
Type of change
How Has This Been Tested?
Just running rspec.