Kit definition part 1 #1904
Merged
Kit definition part 1 #1904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armahillo
reviewed
Sep 24, 2020
armahillo
reviewed
Sep 24, 2020
armahillo
reviewed
Sep 24, 2020
armahillo
reviewed
Sep 24, 2020
armahillo
requested changes
Sep 24, 2020
Collaborator
armahillo
left a comment
armahillo
left a comment
There was a problem hiding this comment.
This is really solid! Nice work.
There was one possible bug (I think you had @item where you meant @kit -- it's noted). Everything else looks great.
added 13 commits
September 25, 2020 09:11
MatthewRDodds
force-pushed
the
1846-kit-definition
branch
from
7fb9df3 to
b2509da
Compare
added 2 commits
September 25, 2020 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
kitsbehind which all of the above is hiddenIssue
Resolves #1846
Type of change
How Has This Been Tested?
Screenshots