Update admin dashboard feature spec to system spec

[jenpen]

Summary:
Rails 5.1 introduced "System Tests", the brave new world of automated testing in Rails. It seems like this has been refined quite a bit and will become more prevalent in Rails 6.0. We'd like to get ahead of the curve on this.

Task:
We need to convert /spec/features/admin/dashboard_spec.rb from a feature spec to a system spec. There are 4 steps to this:

• Create a similarly named file in the spec/system directory. For example if the file was called happy_spec.rb it would be called happy_system_spec.rb in the new directory.
• Set each spec’s type as type: :System
• Use RSpec.describe to define system specs, instead of RSpec.feature
• Replace the scenario alias in previous feature specs with the standard it syntax

Two files have already been converted that you can use as examples -- the account_system_spec.rb spec and the adjustment_system_spec.rb spec. You can also see the original feature files at account_spec.rb spec and adjustment_spec.rb spec.

More information on system specs can be found below.

Reference

• https://edgeguides.rubyonrails.org/testing.html#system-testing
• https://relishapp.com/rspec/rspec-rails/docs/system-specs/system-spec
• https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6
• https://dev.to/aergonaut/running-rails-5-system-tests-on-travis-ci-with-chromedriver-4nm7
• http://blog.mechanicles.com/2018/03/04/gotchas-rails-system-testing.html
• https://everydayrails.com/2018/01/08/rspec-3.7-system-tests.html

[Velisarius]

I'll start working on this.

[Velisarius]

I'm seeing some strange failures I'm struggling to debug after converting this test:

1) Dashboard When the super admin user also has an organization assigned should have a link to return to their organization dashboard on both the side and top nav
     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"

     ActionController::RoutingError:
       No route matches [GET] "/<...>/diaper/tmp/storage/fC/Lf/fCLfNP43YqfVoALq8eeZZWin"

I'm not sure why it's trying to grab something from tmp/storage -- any ideas?

[armahillo]

@Velisarius My first guess would be that it's looking for an organization image or something.

System specs are kind of a new frontier, with all new errors.
If you're still interested in working on this, let us know! (Sorry for self-assigning -- I did it via checkboxes in the issue list, so I didn't see you had chimed in!)

[Velisarius]

@armahillo Thanks for taking this over. I began work with best intentions, but life's caught up with me. I'll circle back on this project when I have some more breathing room in the future. 😅

[armahillo]

@Velisarius Completely understand, not a problem! We'd love to have you back later, when you're able. :)