Include inactive items in distribution reports

[cielf]

Summary

Include inactive items in reports of items that have been distributed

Why

Accuracy -- any now-inactive items that were distributed were, indeed, distributed!

Details

Currently, inactive items are included in the distribution totals in the distribution index, but not in the distributions reports (under Reports, when you are logged in as org_admin1@example.com). These reports include Distribution by County and Itemized distributions

Criteria for completion

• Inactive items included in Distribution by County report
• Inactive items included in Itemized Distributions report
• Test to demonstrate this is so

[donaldwilson8]

Hi! I'm new to this project, and I would love to work on this issue. Looking forward to contributing!

[cielf]

Welcome aboard -- it's yours!

[donaldwilson8]

I've been looking into this, and here are my findings.

• Comparing the total item counts from the distribution index (/distributions) to the distributions by county and itemized distribution reports, I only found a difference of 1 item (119,311 vs 119,310).
• I wrote a test for the distributions by county report service, which created a distribution with inactive items. The service processed this distribution and returned a breakdown that correctly accounted for these inactive items.
• I looked through the relevant models, controllers, and services, and I didn’t find any occurrence of items being filtered by the active scope.

Could I please have some guidance on this issue? Am I overlooking something, or does this mean that inactive items are being processed as desired within these reports?

Thanks for your help!

[cielf]

Hi @donaldwilson8 -- I will double check this, but it might take me a couple of days to get to it. Thanks for your patience!

[cielf]

Checking each report -- does it currently include inactive items ?
Distributions Summary -- no
Distributions by county -- yes
Distributions itemized -- yes

It looks like when we initially wrote down the problem, we got it inside out. The distributions summary should include inactive items to be consistent with the rest of the distribution reports.

My apologies for the mixup.

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.