Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(case_contact): fixed the order of case contacts #6148

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

Raushan998
Copy link

@Raushan998 Raushan998 commented Dec 26, 2024

What github issue is this PR for, if any?

Github issue: Issue#6128

What changed, and why?

Removed the filter button from listing of case_contacts page and added automatic filter has been applied for contact list.

How is this tested? (please write tests!) 💖💪

Manually tested on local enviroment for case_contact filters.
Removed rspec code where filter has been implemented for the validation of rspec.

Screenshots please :)

Screenshot 2024-12-26 at 3 03 45 PM
Screen.Recording.2024-12-26.at.3.04.01.PM.online-video-cutter.com.mp4

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:

😊😊

@github-actions github-actions bot added javascript for use by Github Labeler to mark pull requests that update Javascript code erb labels Dec 26, 2024
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Dec 26, 2024
Copy link
Collaborator

@compwron compwron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, let's see how it goes

@compwron compwron merged commit 9a65487 into rubyforgood:main Jan 2, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
erb javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants