Add notifications for volunteer birthdays (#5316) #5328

davidgumberg · 2023-11-03T22:30:15Z

Resolves #5316

This PR adds notifications for volunteer birthdays.

Adds an optional 'date_of_birth' parameter to the Users model, which is a prerequisite for being able to notify supervisors of upcoming volunteer birthdays.
Adds a birthday_next_month scope to Volunteer, volunteer birthday notification, and rake task for creating the notifications.

Permissions

Volunteers can edit their own DOB, and supervisors and admins from the same org as a volunteer are able to edit the volunteer's DOB.

Tests

I've added tests for the views, and permissions, and a validation rule for the DOB's (they must be in the past.) and for the notification message, and notification rake task.

mattzollinhofer

This is a completely drive by review from a new guy to the area. Please take it or leave it completely. Just wanted to provide a few thoughts. Generally looks good!

app/models/learning_hour.rb

app/validators/user_validator.rb

schoork · 2023-11-04T13:05:28Z

@davidgumberg What's the reasoning behind splitting this into 2 prs?

davidgumberg · 2023-11-04T18:51:30Z

@davidgumberg What's the reasoning behind splitting this into 2 prs?

More than the size of the changes, I just wanted to make sure that adding a date of birth column to the Users table was desired, but since it's only use case is the birthday notification I think I'll make it one PR so they can be looked at together.

app/models/volunteer.rb

schoork · 2023-11-05T12:55:12Z

app/models/volunteer.rb

@@ -57,6 +63,10 @@ class Volunteer < User
                                     .order(:display_name)
                                 }

+  scope :birthday_next_month, -> {
+    where("EXTRACT(month from date_of_birth) = ?", DateTime.now.next_month.month)


Instead of raw SQL, use Rails helpers here

I tried, but could not come up with a way to do this without using EXTRACT

Try this

where(date_of_birth: Date.today.beginning_of_month.next_month..Date.today.end_of_month.next_month)

The problem is that this range will only include date_of_birth's that fall on the next month of this year.

Good point. Yeah, the only solution I saw started to feel over-engineered. There's no user input in this, so that makes me more comfortable. Keep as is.

app/notifications/volunteer_birthday_notification.rb

app/views/notifications/index.html.erb

app/views/users/edit.html.erb

app/views/volunteers/_form.html.erb

config/initializers/date_formats.rb

spec/lib/tasks/volunteer_birthday_reminder_spec.rb

schoork · 2023-11-05T13:11:48Z

Absolutely love all the tests @davidgumberg!

app/controllers/casa_admins_controller.rb

davidgumberg · 2023-11-08T06:16:31Z

@schoork Thanks for the review, I've implemented the suggestions you made (minus using rails helpers for birthday_next_month, which I could not figure out a way to do) and I've also added tests for the two new scopes in the volunteer model.

schoork · 2023-11-08T20:13:45Z

app/decorators/user_decorator.rb

@@ -44,4 +44,16 @@ def formatted_reset_password_sent_at
  def formatted_invitation_sent_at
    formatted_timestamp(:invitation_sent_at)
  end
+
+  def formatted_birthday
+    return "" unless object.date_of_birth.respond_to?(:strftime)


Love the NoMethodError guards.

schoork

Really awesome work @davidgumberg! Love all the tests. Had never heard of the travel_to DATE. That's pretty nifty!

davidgumberg · 2023-11-08T21:08:49Z

Really awesome work @davidgumberg! Love all the tests. Had never heard of the travel_to DATE. That's pretty nifty!

Thanks for the review and feedback!

I got the idea for travel_to from spec/lib/tasks/emancipation_checklist_reminder_spec.rb

bcastillo32 · 2023-12-02T00:53:00Z

@davidgumberg Thanks for the work here. I want to share this update with the casa stakeholders. They will love it. how many days out does the birthday need to be to receive a notification?

davidgumberg · 2023-12-05T17:45:02Z

@davidgumberg Thanks for the work here. I want to share this update with the casa stakeholders. They will love it. how many days out does the birthday need to be to receive a notification?

Thanks @bcastillo32.

Actually, there is a heroku task that will need to be added to run once a month by whoever administers the CASA application, and it will notify volunteers in the same cadence as the youth volunteer reminders, on the 15th (or whichever day of the month the administrator sets the task to run) of each month, users will receive a notification about all volunteer birthdays that are coming in the next month. Please let me know if that behavior is aligned with what the stakeholders requested, and if not, I can write another PR to update the changes to better reflect their request.

bcastillo32 · 2023-12-07T04:00:52Z

@davidgumberg Thanks for the work here. I want to share this update with the casa stakeholders. They will love it. how many days out does the birthday need to be to receive a notification?

Thanks @bcastillo32.

Actually, there is a heroku task that will need to be added to run once a month by whoever administers the CASA application, and it will notify volunteers in the same cadence as the youth volunteer reminders, on the 15th (or whichever day of the month the administrator sets the task to run) of each month, users will receive a notification about all volunteer birthdays that are coming in the next month. Please let me know if that behavior is aligned with what the stakeholders requested, and if not, I can write another PR to update the changes to better reflect their request.

thanks @davidgumberg ! I will reach out to the CASA team to confirm if the proposed schedule suits their requirements. I plan to inform them of the suggested cadence, and if they have any objections and want to propose a different one, we can consider it. Thank you once again for your valuable input!

davidgumberg requested review from compwron, FireLemons and littleforest as code owners November 3, 2023 22:30

github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 erb labels Nov 3, 2023

davidgumberg force-pushed the volunteerbirthdays branch from 6107a2d to f73386a Compare November 3, 2023 22:33

mattzollinhofer reviewed Nov 4, 2023

View reviewed changes

app/models/learning_hour.rb Show resolved Hide resolved

app/validators/user_validator.rb Outdated Show resolved Hide resolved

Add 'date of birth' to Users model

715e687

davidgumberg force-pushed the volunteerbirthdays branch from f73386a to ce8834c Compare November 4, 2023 18:48

davidgumberg force-pushed the volunteerbirthdays branch from c6d9c88 to 319d735 Compare November 5, 2023 05:34

davidgumberg changed the title ~~Add date of birth to Users model; #5316 1/2~~ Add notifications for volunteer birthdays (#5316) Nov 5, 2023

davidgumberg force-pushed the volunteerbirthdays branch from 319d735 to 87d71b5 Compare November 5, 2023 05:47

davidgumberg added 3 commits November 5, 2023 01:50

Add tests for users 'date_of_birth' field

a3a4545

'annotate' gem lint

3631320

Add short ordinal date format

40c1e11

davidgumberg force-pushed the volunteerbirthdays branch 3 times, most recently from a97c1e9 to 6ae6e08 Compare November 5, 2023 07:19

schoork requested changes Nov 5, 2023

View reviewed changes

javiguerra777 reviewed Nov 5, 2023

View reviewed changes

app/controllers/casa_admins_controller.rb Show resolved Hide resolved

davidgumberg force-pushed the volunteerbirthdays branch 3 times, most recently from 694653b to f763e01 Compare November 8, 2023 04:54

Add volunteer birthday notification and task

6f7e2e9

davidgumberg force-pushed the volunteerbirthdays branch from f763e01 to f1f1497 Compare November 8, 2023 05:12

Add tests for volunteer birthday notifications

84f1bc2

davidgumberg added 3 commits November 8, 2023 00:38

Move user DOB formats to decorator

3e0b8cd

Add spec for DOB formatters

684222e

Add a helper for the notifications that are marked read once seen

0ffc83a

davidgumberg force-pushed the volunteerbirthdays branch from f1f1497 to 0ffc83a Compare November 8, 2023 05:38

schoork reviewed Nov 8, 2023

View reviewed changes

schoork approved these changes Nov 8, 2023

View reviewed changes

schoork merged commit e96ff2a into rubyforgood:main Nov 8, 2023
12 checks passed

davidgumberg deleted the volunteerbirthdays branch December 5, 2023 17:45

schoork mentioned this pull request Dec 17, 2023

Periodically cleanup case contact drafts #5442

Open

elasticspoon mentioned this pull request May 27, 2024

alerts supervisors to upcoming volunteer birthdays #5316

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add notifications for volunteer birthdays (#5316) #5328

Add notifications for volunteer birthdays (#5316) #5328

davidgumberg commented Nov 3, 2023 •

edited by elasticspoon

Loading

mattzollinhofer left a comment

schoork commented Nov 4, 2023

davidgumberg commented Nov 4, 2023

schoork Nov 5, 2023

davidgumberg Nov 8, 2023

schoork Nov 8, 2023

davidgumberg Nov 8, 2023

schoork Nov 8, 2023

schoork commented Nov 5, 2023

davidgumberg commented Nov 8, 2023

schoork Nov 8, 2023

schoork left a comment

davidgumberg commented Nov 8, 2023

bcastillo32 commented Dec 2, 2023

davidgumberg commented Dec 5, 2023 •

edited

Loading

bcastillo32 commented Dec 7, 2023

Add notifications for volunteer birthdays (#5316) #5328

Add notifications for volunteer birthdays (#5316) #5328

Conversation

davidgumberg commented Nov 3, 2023 • edited by elasticspoon Loading

Permissions

Tests

mattzollinhofer left a comment

Choose a reason for hiding this comment

schoork commented Nov 4, 2023

davidgumberg commented Nov 4, 2023

schoork Nov 5, 2023

Choose a reason for hiding this comment

davidgumberg Nov 8, 2023

Choose a reason for hiding this comment

schoork Nov 8, 2023

Choose a reason for hiding this comment

davidgumberg Nov 8, 2023

Choose a reason for hiding this comment

schoork Nov 8, 2023

Choose a reason for hiding this comment

schoork commented Nov 5, 2023

davidgumberg commented Nov 8, 2023

schoork Nov 8, 2023

Choose a reason for hiding this comment

schoork left a comment

Choose a reason for hiding this comment

davidgumberg commented Nov 8, 2023

bcastillo32 commented Dec 2, 2023

davidgumberg commented Dec 5, 2023 • edited Loading

bcastillo32 commented Dec 7, 2023

davidgumberg commented Nov 3, 2023 •

edited by elasticspoon

Loading

davidgumberg commented Dec 5, 2023 •

edited

Loading