Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3028 convert csv to excel #5209

Closed
wants to merge 15 commits into from
Closed

Issue 3028 convert csv to excel #5209

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec3e610
feat add Excel data to existing CSV files.
xeniabarreto Sep 5, 2023
c5a318c
Merge branch 'main' into issue-3028-convert-csv-to-excel
xeniabarreto Sep 5, 2023
367637e
fix sheet.add_row
xeniabarreto Sep 8, 2023
fcd9eaf
add modal to export csv/excel
xeniabarreto Sep 8, 2023
6c28b5d
feat formatted automatic line break column in "Case Contact Notes"
xeniabarreto Sep 14, 2023
7334fd4
chore: rubocop
xeniabarreto Sep 15, 2023
f37d9a1
chore: lint
xeniabarreto Sep 15, 2023
4f58744
fix: update test message to match the latest changes for Excel file g…
xeniabarreto Sep 15, 2023
9110d41
chore: remove blank spaces
xeniabarreto Sep 15, 2023
9cf1ab4
chore: added file name for skipping test
xeniabarreto Sep 15, 2023
819b320
chore: Fixed formatting issues in the case contact reports controller
xeniabarreto Sep 19, 2023
e7a1f0c
fix close button Filter Columns modal
xeniabarreto Oct 26, 2023
8c0207a
fix: refactor data columns
xeniabarreto Oct 26, 2023
510c33d
3028 Convert CSV to Excel //
Oct 29, 2023
ff0b6c3
3028 Convert CSV to Excel //
Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: added file name for skipping test
  • Loading branch information
@xeniabarreto
xeniabarreto committed Sep 15, 2023
commit 9cf1ab457e17705d6553f85fbc583eb396e98407
1 change: 1 addition & 0 deletions .allow_skipping_tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ policies/note_policy.rb
presenters/base_presenter.rb
presenters/case_contact_presenter.rb
services/case_contacts_export_csv_service.rb
services/case_contacts_export_excel_service.rb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I am not a fan of skipping tests...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but the methods are hard to test in isolation, and you can test them in the system spec.

services/court_report_format_contact_date.rb
services/create_all_casa_admin_service.rb
services/create_casa_admin_service.rb
Expand Down