Skip to content

Commit

Permalink
feat: quiet sass deprecation warnings (#6027)
Browse files Browse the repository at this point in the history
* feat: quiet sass deprecation warnings

Keep this locked to 1.77.6 until bootstrap 5.3.4 is out
to silence sass deprecation warnings.

See this issue on bootstrap for details:
twbs/bootstrap#40621

* fix: flaky specs
  • Loading branch information
elasticspoon authored Sep 9, 2024
1 parent 4d3bf27 commit 883813c
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 11 deletions.
6 changes: 6 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ updates:
directory: "/"
schedule:
interval: "weekly"
ignore:
# Keep this locked to 1.77.6 until
# bootstrap 5.3.4 is out to silence
# sass deprecation warnings
- dependency-name: "sass"
versions: ["1.77.*", "1.78.*"]

- package-ecosystem: "bundler"
directory: "/"
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"lodash": "^4.17.21",
"luxon": "^3.5.0",
"popper.js": "^1.16.1",
"sass": "^1.77.8",
"sass": "1.77.6",
"select2": "^4.0.13",
"select2-bootstrap-5-theme": "^1.3.0",
"stimulus-rails-nested-form": "^4.1.0",
Expand Down
4 changes: 2 additions & 2 deletions spec/requests/all_casa_admins/casa_orgs_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@
expect { post_create }.to change(ContactTopic, :count).by(2)

casa_org = CasaOrg.last
expect(casa_org.contact_topics.map(&:question)).to eq contact_topics.map { |t| t["question"] }
expect(casa_org.contact_topics.map(&:details)).to eq contact_topics.map { |t| t["details"] }
expect(casa_org.contact_topics.map(&:question)).to match_array(contact_topics.map { |t| t["question"] })
expect(casa_org.contact_topics.map(&:details)).to match_array(contact_topics.map { |t| t["details"] })
expect(casa_org.contact_topics.pluck(:active)).to be_all true
end

Expand Down
10 changes: 6 additions & 4 deletions spec/views/notifications/index.html.erb_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@
notifications_html = Nokogiri::HTML5(rendered).css(".list-group-item")
patch_note_index = notifications_html.index { |node| node.text.include?("Patch Notes") }

expect(notifications_html[0].text).to match(/User \d+ has flagged a Case Contact that needs follow up/)
expect(notifications_html[1].text).to match(/Your case CINA-\d+ is a transition aged youth/)
expect(notifications_html[2].text).to match(/Your youth, case number: CINA-\d+ has a birthday next month/)
expect(patch_note_index).to eq(3)
aggregate_failures do
expect(notifications_html[0].text).to match(/User \d+ has flagged a Case Contact that needs follow up/)
expect(notifications_html[1].text).to match(/Your case CINA-\d+ is a transition aged youth/)
expect(notifications_html[2].text).to match(/Your youth, case number: CINA-\d+ has a birthday next month/)
expect(patch_note_index).to eq(3)
end
end

it "has all notifications created before the deploy date below the patch note" do
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5136,10 +5136,10 @@ safe-regex-test@^1.0.0:
resolved "https://registry.npmjs.org/safer-buffer/-/safer-buffer-2.1.2.tgz"
integrity sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg==

sass@^1.77.8:
version "1.77.8"
resolved "https://registry.yarnpkg.com/sass/-/sass-1.77.8.tgz#9f18b449ea401759ef7ec1752a16373e296b52bd"
integrity sha512-4UHg6prsrycW20fqLGPShtEvo/WyHRVRHwOP4DzkUrObWoWI05QBSfzU71TVB7PFaL104TwNaHpjlWXAZbQiNQ==
sass@1.77.6:
version "1.77.6"
resolved "https://registry.yarnpkg.com/sass/-/sass-1.77.6.tgz#898845c1348078c2e6d1b64f9ee06b3f8bd489e4"
integrity sha512-ByXE1oLD79GVq9Ht1PeHWCPMPB8XHpBuz1r85oByKHjZY6qV6rWnQovQzXJXuQ/XyE1Oj3iPk3lo28uzaRA2/Q==
dependencies:
chokidar ">=3.0.0 <4.0.0"
immutable "^4.0.0"
Expand Down

0 comments on commit 883813c

Please sign in to comment.