feat: added extra sources in initializer #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misdoro
reviewed
Nov 8, 2024
pkuczynski
changed the title
pkuczynski
requested review from
cjlarose,
misdoro and
rdubya
and removed request for
misdoro
Member
|
@Nuzair46 after finally fixing CI and refreshing this branch, some of the tests fail (unfortunatelly). Would you like having a look? |
Member
Author
|
@pkuczynski you can run the ci now |
Member
|
@Nuzair46 can you resolve the conflict? |
pkuczynski
approved these changes
Jul 11, 2025
pkuczynski
requested review from
misdoro and
pkuczynski
and removed request for
cjlarose,
misdoro and
rdubya
pkuczynski
approved these changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Adds ability to set extra_sources at initializer level.